From 84f89455822de1087ddcedee49dcb27505f09f7a Mon Sep 17 00:00:00 2001 From: Daniel McCoy Stephenson Date: Fri, 25 Sep 2026 19:04:40 -0600 Subject: [PATCH] Point the stale web/game-worker.js references at tak's worker The Worker moved into tak in #197 and web/game-worker.js was deleted, but four comments still named it. The Dockerfile's note also still said the server doesn't need tak and is pure stdlib - web/serve.py is now tak.web.serve, serving the kit's assets at /tak/. requirements.txt still said FishE was "being moved back onto" tak one module at a time; that move finished with #197. Co-Authored-By: Claude Opus 5.5 --- Dockerfile | 11 ++++++----- requirements.txt | 4 ++-- src/config/config.py | 2 +- tests/ui/test_pyodideUserInterface.py | 4 ++-- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/Dockerfile b/Dockerfile index d8d6227..8858dd6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -7,11 +7,12 @@ WORKDIR /app # game in the player's own tab, with that tab's IndexedDB holding the saves. # # Two consequences worth spelling out: -# - The only pip install is tak, the kit the game imports from: it is -# installed so web/build_zip.py can copy it into the bundle (and it is -# what the browser runs), not because the server needs it. jsonschema is -# loaded browser-side by web/game-worker.js, and the server here is pure -# stdlib. git is needed for that one install and removed afterwards. +# - The only pip install is tak, the kit the game imports from: web/serve.py +# is tak's static server (tak.web.serve), which also hands out the kit's +# page assets and Worker at /tak/, and web/build_zip.py copies tak into +# the bundle the browser runs. jsonschema is loaded browser-side by tak's +# game-worker.js, so the server never imports it. git is needed for that +# one install and removed afterwards. # - No save directory, and no volume to persist. Every visitor gets their own # game and their own save slots, which is exactly what the server-backed # front-end (examples/web_app.py) could not give them. diff --git a/requirements.txt b/requirements.txt index 60b28dc..282a905 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,7 +5,7 @@ # separately if you want UIType.PYGAME. # # tak is the text-adventure kit extracted from this game -# (https://github.com/Stephenson-Software/tak); FishE is being moved back onto -# it one module at a time. Installing it needs git on the PATH. +# (https://github.com/Stephenson-Software/tak), which FishE now runs on. +# Installing it needs git on the PATH. tak @ git+https://github.com/Stephenson-Software/tak@v0.2.0 jsonschema>=4.0,<5.0 diff --git a/src/config/config.py b/src/config/config.py index edb35fc..e73724e 100644 --- a/src/config/config.py +++ b/src/config/config.py @@ -28,7 +28,7 @@ def __init__(self): # which deployments use to point the game somewhere other than a # cwd-relative "data" — a mounted volume for a server install, or the # Worker-side directory that the Pyodide front-end mirrors to the - # browser's IndexedDB (see browserSaveSync and web/game-worker.js). + # browser's IndexedDB (see browserSaveSync and tak's game-worker.js). self.dataDirectory = os.environ.get("FISHE_SAVE_DIR") or "data" # Initial player values. Starting energy isn't configured here - see diff --git a/tests/ui/test_pyodideUserInterface.py b/tests/ui/test_pyodideUserInterface.py index 6e23e5e..84753af 100644 --- a/tests/ui/test_pyodideUserInterface.py +++ b/tests/ui/test_pyodideUserInterface.py @@ -315,7 +315,7 @@ def test_a_game_played_in_the_browser_saves_into_browser_storage(fakeJs): """ from fishE import FishE - # Mirror of makeSyncSaves() in web/game-worker.js: walk the save directory + # Mirror of makeSyncSaves() in tak's game-worker.js: walk the save directory # and hand the file map to the browser to store. browserStorage = {} @@ -358,7 +358,7 @@ def syncSaves(): def test_quitting_ends_the_page_instead_of_raising(fakeJs): # "Quit" calls exit(), which in a tab has no process to end: the Worker # would report it as an error rather than the game finishing. The entry - # point is exec'd here the same way web/game-worker.js runs it. + # point is exec'd here the same way tak's game-worker.js runs it. entryPoint = os.path.join( os.path.dirname(__file__), "..", "..", "web", "pyodide_main.py" )