Apply Gitar review fixes

Author: aurelien-coet-sonarsource

java-checks/src/main/java/org/sonar/java/checks/unused/UnusedLocalVariableCheck.java

@@ -114,11 +114,11 @@ private static boolean isRValue(IdentifierTree tree) {
       return assignment.variable() != tree;
     }
     if (parent == null) {
-      return false;
+      return true;
     }
     Tree grandParent = parent.parent();
     // Note that an expression statement can't be a parenthesized expression, so we don't need to skip parentheses here
-    return grandParent != null && !(parent.is(INCREMENT_KINDS) && grandParent.is(Tree.Kind.EXPRESSION_STATEMENT));
+    return !(parent.is(INCREMENT_KINDS) && grandParent != null && grandParent.is(Tree.Kind.EXPRESSION_STATEMENT));
   }
 
   private static boolean isProperLocalVariable(VariableTree variable) {

java-frontend/src/main/java/org/sonar/java/reporting/JavaQuickFix.java

@@ -93,15 +93,15 @@ public int compare(JavaTextEdit a, JavaTextEdit b) {
         AnalyzerMessage.TextSpan first = a.getTextSpan();
         AnalyzerMessage.TextSpan second = b.getTextSpan();
 
-        int result = first.startLine - second.startLine;
+        int result = Integer.compare(first.startLine, second.startLine);
         if (result != 0) {
           return result;
         }
-        result = first.startCharacter - second.startCharacter;
+        result = Integer.compare(first.startCharacter, second.startCharacter);
         if (result != 0) {
           return result;
         }
-        result = first.endLine - second.endLine;
+        result = Integer.compare(first.endLine, second.endLine);
         if (result != 0) {
           return result;
         }