From 45b5e805ae883190ebc852d929127491d2abf317 Mon Sep 17 00:00:00 2001 From: Shuhao Date: Sat, 14 Nov 2026 16:40:06 -0500 Subject: [PATCH] ci: run the oracle check on factory/ PRs only MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The release PR (dev → master, #150) failed it: across the release range, #91's commits legitimately updated tests in #90's and #107's oracles, and the check counts every later commit. The factory README already scopes it to a factory/ PR, where an oracle is frozen for its own issue's build; each feature PR into dev still runs it there. --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db4c219..1b52088 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,7 +40,12 @@ jobs: run: npm test - name: Zoom-client specs are well formed run: npm run test:specs + # A factory/ PR only, as .factory/README.md says: an oracle is frozen for its own + # issue's build. Across a release PR (dev → master) later issues legitimately update + # earlier oracles' tests (#91 did #90's and #107's), and each of them already passed + # this check on its own factory/ PR into dev. - name: Oracle tests untouched since the oracle commit + if: startsWith(github.head_ref, 'factory/') run: node scripts/factory/check-oracle.mjs --base origin/${{ github.base_ref || 'dev' }} - name: Build run: npm run build