Skip to content

Commit 5f5bde0

Browse files
committed
use value * 1e-6
1 parent 8571768 commit 5f5bde0

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

ratapi/inputs.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,10 +366,11 @@ def make_problem(project: ratapi.Project, validate_range: bool = False) -> Probl
366366
prior_values.append([prior_id[param.prior_type], param.mu, param.sigma])
367367
check_list.append(int(param.fit))
368368
if param.fit:
369-
if validate_range and (param.max - param.min) < 1e-10:
369+
min_range = abs(param.value) * 1e-6 if param.value == 0 else 1e-6
370+
if validate_range and (param.max - param.min) < min_range:
370371
warnings.warn(
371372
f'{class_list.replace("_", " ").title()} "{param.name}" was removed from the '
372-
"fit because its range is too small (< 1e-10).",
373+
f"fit because its range is too small (< {min_range:g}).",
373374
stacklevel=2,
374375
)
375376
check_list[-1] = 0

tests/test_inputs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ def test_make_problem_validate_range(request) -> None:
491491
problem = make_problem(test_project)
492492
assert problem.checks.scalefactors[0] == 1
493493

494-
with pytest.warns(UserWarning, match="was removed from the fit because its range is too small \(< 1e-10\)"):
494+
with pytest.warns(UserWarning, match="was removed from the fit because its range is too small \(< 1e-06\)"):
495495
problem = make_problem(test_project, True)
496496
assert problem.checks.scalefactors[0] == 0
497497

0 commit comments

Comments
 (0)