You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2 (new_features, closed as "reconciled into #17") bundled several things beyond the SQL-schema changes. A line-by-line diff comparison of PR #2 against PR #17's current diff (and current master) confirms the SQL/schema/trigger/function changes are fully carried forward (in some cases further simplified, e.g. PR #17 later dropped _object_oid.object_oid entirely). However, two pieces of non-SQL content from PR #2 are not present anywhere in master, PR #17, or the rest of the open reconcile-object-functions -> u-and-u-testing -> u-and-u-extension-update-ci stack (#17, #18, #19).
1. README.md (missing entirely)
PR #2 added a new 333-line README.md documenting the framework: installation, the two schemas (object_reference/_object_reference), the object_reference__usage / object_reference__dependency roles, key concepts (objects vs OIDs, object groups, DDL capture, referring to objects), and a full API reference for every public function (object__getsert, object__getsert_w_group_id, object__describe, object__identity, object_group__create, object_group__get, object_group__remove, etc).
There is no README.md on master, and none of #17/#18/#19 add one. The closest thing on master is doc/object_reference.adoc, which is a 5-line stub about pg_dump support only -- it does not cover installation, roles, or the API.
PR #2 also fixed several stale packaging metadata fields that are still wrong on current master:
runtime.requires is missing cat_tools entirely (only lists plpgsql: 0), even though cat_tools is a hard runtime dependency (object_reference.control's requires = 'cat_tools, count_nulls', soon to be 'cat_tools' once Remove reg* pseudotype columns; add object info functions #17 merges).
resources.homepage / bugtracker.web / repository.url / repository.web still point at decibel/object_reference and generated_by still points at decibel/pgxntool, even though the project has moved to the Postgres-Extensions org (confirmed by object_reference.control, the repo's own remote, and pgxntool's own META already using Postgres-Extensions/pgxntool).
#17 is an actively-managed, currently open PR in a live stack (#17 -> #18 -> #19). Rather than push directly to reconcile-object-functions and risk colliding with in-flight work, filing this separately so the two items above can be triaged and picked up deliberately (either folded into #17 or done as standalone follow-ups).
Background
PR #2 (
new_features, closed as "reconciled into #17") bundled several things beyond the SQL-schema changes. A line-by-line diff comparison of PR #2 against PR #17's current diff (and currentmaster) confirms the SQL/schema/trigger/function changes are fully carried forward (in some cases further simplified, e.g. PR #17 later dropped_object_oid.object_oidentirely). However, two pieces of non-SQL content from PR #2 are not present anywhere inmaster, PR #17, or the rest of the openreconcile-object-functions->u-and-u-testing->u-and-u-extension-update-cistack (#17, #18, #19).1. README.md (missing entirely)
PR #2 added a new 333-line
README.mddocumenting the framework: installation, the two schemas (object_reference/_object_reference), theobject_reference__usage/object_reference__dependencyroles, key concepts (objects vs OIDs, object groups, DDL capture, referring to objects), and a full API reference for every public function (object__getsert,object__getsert_w_group_id,object__describe,object__identity,object_group__create,object_group__get,object_group__remove, etc).There is no
README.mdonmaster, and none of #17/#18/#19 add one. The closest thing onmasterisdoc/object_reference.adoc, which is a 5-line stub about pg_dump support only -- it does not cover installation, roles, or the API.Source: PR #2 diff,
README.md, new file, lines 1-333 (gh pr diff 2 --repo Postgres-Extensions/object_reference).2. META.json / META.in.json metadata fixes (missing entirely)
PR #2 also fixed several stale packaging metadata fields that are still wrong on current
master:runtime.requiresis missingcat_toolsentirely (only listsplpgsql: 0), even thoughcat_toolsis a hard runtime dependency (object_reference.control'srequires = 'cat_tools, count_nulls', soon to be'cat_tools'once Remove reg* pseudotype columns; add object info functions #17 merges).resources.homepage/bugtracker.web/repository.url/repository.webstill point atdecibel/object_referenceandgenerated_bystill points atdecibel/pgxntool, even though the project has moved to thePostgres-Extensionsorg (confirmed by object_reference.control, the repo's own remote, and pgxntool's own META already usingPostgres-Extensions/pgxntool).build.requires.PostgreSQLis still"9.5.0"; PR Add object functions, modernize CI, and remove reg* pseudotypes #2 bumped it to"13.0".None of #17/#18/#19 touch
META.jsonorMETA.in.json.Source: PR #2 diff,
META.json/META.in.jsonhunks (gh pr diff 2 --repo Postgres-Extensions/object_reference).Why a new issue instead of folding into #17
#17 is an actively-managed, currently open PR in a live stack (#17 -> #18 -> #19). Rather than push directly to
reconcile-object-functionsand risk colliding with in-flight work, filing this separately so the two items above can be triaged and picked up deliberately (either folded into #17 or done as standalone follow-ups).