Fix the failures outside the dashboard, then use "Update to latest main & restart" above, or release anyway after a confirmation.
+
+
- Not available: QA did not run.
- Available once every QA lane has finished.
+ Not available: QA did not run.
+ Available once every QA lane has finished.
-
+
+
+ Makes "Release" available without QA. Asks for confirmation.
+
+
+
+
diff --git a/frontend/src/components/release/ReleaseWizard.test.ts b/frontend/src/components/release/ReleaseWizard.test.ts
index b5b25da..cd5f40a 100644
--- a/frontend/src/components/release/ReleaseWizard.test.ts
+++ b/frontend/src/components/release/ReleaseWizard.test.ts
@@ -132,6 +132,7 @@ describe('ReleaseWizard', () => {
expect(status({ step: 'sync', sync_state: 'running' })).toBe('waiting|Step 3 of 5 · Pre-release sync|Copying staging into the pre-release')
expect(status({ step: 'sync', sync_state: 'failure' })).toBe('failed|Step 3 of 5 · Pre-release sync|The pre-release sync failed')
expect(status({ step: 'qa', sync_state: 'success', qa: qa('waiting') })).toBe('action|Step 4 of 5 · QA|Your turn: approve the QA run')
+ expect(status({ step: 'qa', sync_state: 'success', qa: { ...qa('waiting'), skipped: true } })).toBe('action|Step 4 of 5 · QA|Your turn: QA skipped, release when ready')
expect(status({ step: 'qa', sync_state: 'success', qa: qa('running') })).toBe('waiting|Step 4 of 5 · QA|QA is running')
expect(status({ step: 'qa', sync_state: 'success', qa: qa('failure') })).toBe('failed|Step 4 of 5 · QA|QA could not start')
expect(status({ step: 'qa', sync_state: 'success', qa: qa('finished', [lane('success')]) })).toBe('action|Step 4 of 5 · QA|Your turn: QA passed, release when ready')
diff --git a/frontend/src/components/release/ReleaseWizard.vue b/frontend/src/components/release/ReleaseWizard.vue
index becd330..dd09f19 100644
--- a/frontend/src/components/release/ReleaseWizard.vue
+++ b/frontend/src/components/release/ReleaseWizard.vue
@@ -36,7 +36,7 @@ const readOnly = computed(() => ['sync', 'qa', 'releasing'].includes(props.relea
const draftsKept = computed(() => props.release.step !== 'changelog' && hasDrafts(props.release.id))
const ACTION_WORDS: Record = {
cut: 'started the release', save_changelog: 'edited the changelog', approve_changelog: 'approved the changelog',
- retry_sync: 'retried the sync', approve_qa: 'approved the QA run', retry_qa: 'retried QA', recut: 'updated to latest main',
+ retry_sync: 'retried the sync', approve_qa: 'approved the QA run', retry_qa: 'retried QA', skip_qa: 'skipped QA', recut: 'updated to latest main',
release: 'released', retry_release: 'retried the final sync', abandon: 'abandoned',
}
const when = (iso: string) => {
@@ -118,6 +118,7 @@ const status = computed(() => {
return wait('Copying staging into the pre-release')
case 'qa': {
const q = r.qa
+ if (q?.skipped && q.state !== 'finished') return act('QA skipped, release when ready')
if (!q || q.state === 'waiting') return act('approve the QA run')
if (q.state === 'failure') return fail('QA could not start')
if (q.state === 'running') return wait('QA is running')
diff --git a/frontend/src/composables/useRelease.ts b/frontend/src/composables/useRelease.ts
index 232fc85..2932e05 100644
--- a/frontend/src/composables/useRelease.ts
+++ b/frontend/src/composables/useRelease.ts
@@ -96,7 +96,7 @@ function shown(id: string): string | undefined {
if (!r) return undefined
return JSON.stringify([
r.step, r.head_sha, r.cut?.state, r.sync_state, r.sync?.map((c) => c.state),
- r.qa?.state, r.qa?.lanes?.length, r.final?.state,
+ r.qa?.state, r.qa?.skipped, r.qa?.lanes?.length, r.final?.state,
])
}
diff --git a/frontend/src/types/release.ts b/frontend/src/types/release.ts
index 3de2e06..363581d 100644
--- a/frontend/src/types/release.ts
+++ b/frontend/src/types/release.ts
@@ -72,8 +72,9 @@ export interface ReleaseState {
sync_error: string
sync: InstanceCard[]
removals: { project: string; item: string }[]
+ // skipped: a user chose to release this head of the PR without QA; Release is then available whatever the state.
// url: the QA run ('' while none). error: why QA could not run, set with state 'failure'.
- qa: { state: 'waiting' | 'running' | 'finished' | 'failure'; lanes: Lane[]; url: string; error: string } | null
+ qa: { state: 'waiting' | 'running' | 'finished' | 'failure'; lanes: Lane[]; url: string; error: string; skipped?: boolean; skipped_by?: string } | null
final: {
tags: string[]
instances: InstanceCard[]
@@ -116,4 +117,4 @@ export interface HistoryPage {
}
export type ReleaseAction =
- | 'approve-changelog' | 'retry-sync' | 'approve-qa' | 'retry-qa' | 'recut' | 'release' | 'retry-release' | 'abandon'
+ | 'approve-changelog' | 'retry-sync' | 'approve-qa' | 'retry-qa' | 'skip-qa' | 'recut' | 'release' | 'retry-release' | 'abandon'