Commit b4ef220
authored
docs: correct span-drop diagnostic field (#841)
#### Overview
Correct the documented runtime diagnostic field for dropped OTLP spans on the 0.8 release branch and cover the production constructor path.
- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.
#### Details
- Update the `otel.spans_dropped` diagnostic documentation from `opentelemetry.endpoints[N].endpoint` to the emitted `opentelemetry.traces[N].endpoint` field path.
- Align the existing dropped-span diagnostic fixture with that field path.
- Add a focused regression test that constructs the subscriber with `new_for_plugin` and asserts the runtime diagnostic field in the active plugin report.
#### Where should the reviewer start?
`crates/core/tests/unit/observability/otel_tests.rs`, which now verifies the constructor-produced field path; then review the documentation warning in `docs/configure-plugins/observability/opentelemetry.mdx`.
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Relates to: RELAY-767
## Summary by CodeRabbit
* **Bug Fixes**
* Corrected OpenTelemetry diagnostics to reference the appropriate trace endpoint path when reporting dropped spans.
* Improved metric validation diagnostics for invalid endpoint configurations, including plugin-managed setups.
* **Documentation**
* Updated observability documentation to reflect the corrected version-4 trace endpoint path used in diagnostic messages.
Authors:
- Bryan Bednarski (https://github.com/bbednarski9)
Approvers:
- Eric Evans II (https://github.com/ericevans-nv)
- Will Killian (https://github.com/willkill07)
URL: #8411 parent f1d8e86 commit b4ef220
2 files changed
Lines changed: 47 additions & 3 deletions
File tree
- crates/core/tests/unit/observability
- docs/configure-plugins/observability
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4377 | 4377 | | |
4378 | 4378 | | |
4379 | 4379 | | |
4380 | | - | |
| 4380 | + | |
4381 | 4381 | | |
4382 | 4382 | | |
4383 | 4383 | | |
| |||
4415 | 4415 | | |
4416 | 4416 | | |
4417 | 4417 | | |
4418 | | - | |
| 4418 | + | |
4419 | 4419 | | |
4420 | 4420 | | |
4421 | 4421 | | |
| |||
4431 | 4431 | | |
4432 | 4432 | | |
4433 | 4433 | | |
| 4434 | + | |
| 4435 | + | |
| 4436 | + | |
| 4437 | + | |
| 4438 | + | |
| 4439 | + | |
| 4440 | + | |
| 4441 | + | |
| 4442 | + | |
| 4443 | + | |
| 4444 | + | |
| 4445 | + | |
| 4446 | + | |
| 4447 | + | |
| 4448 | + | |
| 4449 | + | |
| 4450 | + | |
| 4451 | + | |
| 4452 | + | |
| 4453 | + | |
| 4454 | + | |
| 4455 | + | |
| 4456 | + | |
| 4457 | + | |
| 4458 | + | |
| 4459 | + | |
| 4460 | + | |
| 4461 | + | |
| 4462 | + | |
| 4463 | + | |
| 4464 | + | |
| 4465 | + | |
| 4466 | + | |
| 4467 | + | |
| 4468 | + | |
| 4469 | + | |
| 4470 | + | |
| 4471 | + | |
| 4472 | + | |
| 4473 | + | |
| 4474 | + | |
| 4475 | + | |
| 4476 | + | |
| 4477 | + | |
4434 | 4478 | | |
4435 | 4479 | | |
4436 | 4480 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
| 286 | + | |
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
| |||
0 commit comments