Skip to content

Commit 077aec7

Browse files
Stop constraining grid cell editors to the viewport (#317)
## Rationale Tabbing past the right edge of the window in a wide EHR data-entry grid draws the cell editor over the wrong column and never scrolls the page, so the user types into a box that appears to belong to one column while the value goes to another. The LDK cell-editing plugin aligned editors with a trailing `?`, which tells Ext to clamp the editor inside the browser viewport; EHR grids grow to fit their columns and rely on the page to scroll, so the clamp pinned off-screen editors to the window edge and left the browser nothing to scroll to. With the constraint removed the editor sits on its cell and focusing it scrolls the page, so tabbing beyond the width of the screen now scrolls horizontally to follow the active cell. ## Related Pull Requests None. ## Changes - Drop the viewport constraint from the cell editor alignment in the LDK cell-editing plugin, so editors always align to their cell and the page scrolls to keep the active editor visible.
1 parent d8f9e68 commit 077aec7

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎LDK/resources/web/LDK/plugin/CellEditing.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ Ext4.define('LDK.grid.plugin.CellEditing', {
5353
hasCellEditOverrides: true,
5454
revertInvalid: false,
5555
completeOnEnter: false,
56-
alignment: 'tl-tl?'
56+
// No trailing '?': viewport-constraining pins editors for off-screen columns to the window edge instead of their cell
57+
alignment: 'tl-tl'
5758
});
5859

5960
//NOTE: this is an override to fix an Ext4 bug involving revertInvalid

0 commit comments

Comments
 (0)