Skip to content

GALIL: zero encoder when open loop? #9004

Description

@FreddieAkeroyd

Question on new galil driver - should it call DE even if open loop when it homes? An edge case of if you have a working encoder but home with UEIP set to no and then turn encoder on afterwards. The current behavior is the same as the old driver so not a change. If a motor position is explicitly redefined post home, a check on ueip is not made, so calling DE in all cases may be more consistent?

GalilAxis::jogAfterHome(void) 

          //Program encoder position register
          // question: should we do this even if ueip is false? If you home an axis with ueip false and then turn on the encoder should it work?
          // setPosition / setEncoderPosition don't check ueip
          if (ueip_ || motorIsServo_) {
             sprintf(pC_->cmd_, "DE%c=0", axisName_);
             pC_->sync_writeReadController();
          }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions