Skip to content

49 of 67 components have never been examined for a grounding #174

Description

@realmarcin

Found in an open-issue review. Filed because the queue had no issue for the
largest content gap in the corpus.

grounded                      6
REVIEWED_LABEL_ONLY          12   (looked at, deliberately declined)
no grounding, no status      49   (never examined)

Of the 49 never examined, 35 carry gene_symbols and 6 carry
protein_examples, so most have something to match on.

This is not "run the adopted script"

I nearly filed this as a mechanical gap and it is not one.
scripts/interpro_groundings.py is a curator-reviewed allow-list, not a
matcher — its own docstring says it "never searches labels or chooses the first
result". Running it today touches 8 components and writes nothing:

bacterial_type_flagellum#flagellin   InterPro:IPR001492    unchanged
carboxysome#bmc_h                    REVIEWED_LABEL_ONLY   unchanged
carboxysome#bmc_p                    REVIEWED_LABEL_ONLY   unchanged
... 5 more REVIEWED_LABEL_ONLY
nothing to write

Seven of its eight entries resolved to REVIEWED_LABEL_ONLY — the adapter
looked and declined because the family consensus was ambiguous across the
component's scope. That is the adapter working correctly, and it is why only
2 of the 6 groundings are InterPro at all (the other four are CHEBI and SO).

So the gap is not un-run tooling. It is 49 components nobody has reviewed, and
closing it means extending the allow-list one component at a time with a
recorded decision — including recording "declined, and why", which is what
REVIEWED_LABEL_ONLY exists to say.

Suggested shape

Batch by record rather than corpus-wide, largest first — carboxysome (8),
flagellum (7), ATP synthase (5), injectisome (5) — so each batch is one
coherent review against one structure's scope.

bacterial_type_flagellum already has an open component_groundings
CURATION_TODO covering its 7; that discussion and this issue should not drift
apart.

Why it matters

components is where this corpus says what a structure is made of. Without
groundings those components are labels and gene symbols — not resolvable
identifiers — so nothing downstream can join them to protein data, and the
just validate-products id↔label gate has nothing to check.

Related: #7 item 3 asks for exactly this on the flagellum.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Real and schedulable: a gate gap or a correctness issueenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions