Skip to content

ch5-video no longer tells all ch5-background to let video through #273

Description

@jadeva

TB Case#: 00198843

Since commit 95a46ec video does not show through multiple ch5-backgrounds.

Previously you fetches all ch5-background elements to tell them to let the video though.
In the mentioned commit you changed this to only let video through on a hardcoded element id (used by the shell template) and a parent ch5-background.

The issue can easily be seen on line 460 in ch5-video.ts in the new commit.

From:

private ch5BackgroundElements: HTMLCollectionOf<Ch5Background> = document.getElementsByTagName('ch5-background') as HTMLCollectionOf<Ch5Background>;

To:

private shellCh5Background: Ch5Background | null = document.getElementById('template-content-background') as Ch5Background;
private parentCh5Background: Ch5Background | null = null;

We really need the video to be able to go through multiple ch5-backgrounds.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions