From 8db5e8d9bca42fbe0eb3d02aa068eac31392c41f Mon Sep 17 00:00:00 2001 From: OpenGithubs Date: Mon, 12 Oct 2026 18:04:48 +0800 Subject: [PATCH] fix: log MCP client close errors instead of silently swallowing them client.close() failures were completely suppressed with an empty catch. This masked MCP connection leaks and transport errors in server logs. Now we log the failure reason so operators can diagnose stuck connections. --- src/server/connections.ts | 2 +- src/server/parallel.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/connections.ts b/src/server/connections.ts index 182b0368..cfcb0a18 100644 --- a/src/server/connections.ts +++ b/src/server/connections.ts @@ -165,7 +165,7 @@ export class ConnectionService { }); return await use(client, bounded); } finally { - await client.close().catch(() => {}); + await client.close().catch((err) => console.error('Failed to close MCP client:', err.message)); } } private async discover( diff --git a/src/server/parallel.ts b/src/server/parallel.ts index cf6f6131..214d5a8c 100644 --- a/src/server/parallel.ts +++ b/src/server/parallel.ts @@ -195,6 +195,6 @@ export async function parallelSources( throw new Error('Parallel could not extract usable source evidence.'); return pages; } finally { - await client.close().catch(() => {}); + await client.close().catch((err) => console.error('Failed to close MCP client:', err.message)); } }