Skip to content

Commit 1f21226

Browse files
sawenzeljackal1-66claude
committed
Leave the loopers ownership to O2 and use -colBkg for both transports
This applies the reviewer's suggestion so that the workflow works together with the ownership of collisions in O2. - The signal no longer gets GenTPCLoopers.loopersVeto=true unless loopers are switched off. - Both transports take GenTPCLoopers.colsys from -colBkg. AliceO2Group/AliceO2#16015 Co-authored-by: Marco Giacalone <mgiacalo@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent c12c033 commit 1f21226

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎MC/bin/o2dpg_sim_workflow.py‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,7 @@ def extractVertexArgs(configKeyValuesStr, finalDiamondDict):
528528
COLTYPEBKG=args.colBkg
529529
havePbPb = (COLTYPE == 'PbPb' or (doembedding and COLTYPEBKG == "PbPb"))
530530

531-
# TPC loopers are a background continuous in time: with embedding they are generated
532-
# by the background transport only, otherwise background and signal both cover the timeframe
531+
# TPC loopers are a background effect: with embedding, background and signal get consistent loopers settings
533532
if doembedding:
534533
def loopersKeys(confkey):
535534
return [kv.strip() for kv in confkey.split(';') if kv.strip().startswith('GenTPCLoopers.')]
@@ -539,10 +538,13 @@ def loopersVetoed(confkey):
539538
if loopersVetoed(args.confKey) or loopersVetoed(args.confKeyBkg):
540539
print('o2dpg_sim_workflow: TPC loopers switched off for background and signal')
541540
args.confKeyBkg = args.confKeyBkg + ';GenTPCLoopers.loopersVeto=true'
541+
args.confKey = args.confKey + ';GenTPCLoopers.loopersVeto=true'
542542
else:
543-
# loopers settings given for the signal apply to the background; the background's own settings take precedence
543+
# Loopers settings given for the signal apply to the background as well; the background's own
544+
# settings take precedence. Both transports take colsys from -colBkg, as the loopers are a background effect.
545+
# Which transport generates the loopers of a given collision is decided in O2, from the collision context itself.
544546
args.confKeyBkg = ';'.join(loopersKeys(args.confKey) + ['GenTPCLoopers.colsys=' + COLTYPEBKG, args.confKeyBkg])
545-
args.confKey = args.confKey + ';GenTPCLoopers.loopersVeto=true'
547+
args.confKey = ';'.join(['GenTPCLoopers.colsys=' + COLTYPEBKG, args.confKey])
546548

547549
workflow={}
548550
workflow['stages'] = []

0 commit comments

Comments
 (0)