Skip to content

Commit 70d3edd

Browse files
committed
TPC SCD: fix getDXI off-by-one for row 127
Row 127 (the first row of OROC3, NRowsAccumulated[2] = 127) failed the check ix > NRowsAccumulated[NROCTypes - 2] and fell through to the OROC2 branch, so it got the OROC2 pad height (1/1.2 cm^-1 instead of 1/1.5 cm^-1). This affects the x-kernel width of TrackResiduals::getSmoothEstimate when the closest voxel is in row 127, and the x mean-position validity check in TPCFastSpaceChargeCorrectionHelper for that row. Only non-uniform (per pad row) x-binning is affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 1f4567d commit 70d3edd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎Detectors/TPC/calibration/SpacePoints/include/SpacePoints/TrackResiduals.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -552,8 +552,8 @@ inline float TrackResiduals::getDXI(int ix) const
552552
if (ix < param::NRowsPerROC[0]) {
553553
// we are in the IROC
554554
return 1.f / param::RowDX[0];
555-
} else if (ix > param::NRowsAccumulated[param::NROCTypes - 2]) {
556-
// we are in the last OROC
555+
} else if (ix >= param::NRowsAccumulated[param::NROCTypes - 2]) {
556+
// we are in the last OROC (rows 127 - 151)
557557
return 1.f / param::RowDX[param::NROCTypes - 1];
558558
} else if (ix < param::NRowsAccumulated[1]) {
559559
// OROC1

0 commit comments

Comments
 (0)