From 2ed5d8c4f9401d268c66b0fb6734b9b79455412a Mon Sep 17 00:00:00 2001
From: Anthony White <519934+antwonw@users.noreply.github.com>
Date: Tue, 8 Sep 2026 12:55:34 -0700
Subject: [PATCH] Ensure Icon Picker only calls wp_get_attachment_image_url
 with valid attachment IDs (Fixes #1032)

---
 includes/fields/class-acf-field-icon_picker.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/includes/fields/class-acf-field-icon_picker.php b/includes/fields/class-acf-field-icon_picker.php
index d331bcb9..c1f28ee9 100644
--- a/includes/fields/class-acf-field-icon_picker.php
+++ b/includes/fields/class-acf-field-icon_picker.php
@@ -214,8 +214,13 @@ class="acf-icon-picker-media-library-preview"
 								>
 									<div class="acf-icon-picker-media-library-preview-img" style="<?php echo esc_attr( 'media_library' !== $field['value']['type'] ? 'display: none;' : '' ); ?>">
 										<?php
-											$img_url = wp_get_attachment_image_url( $field['value']['value'], 'thumbnail' );
-											// If the type is media_library, then we need to show the media library preview.
+										$img_url = '';
+
+										// Only fetch attachment image URL when the field type is media_library and the ID is valid.
+										if ( 'media_library' === $field['value']['type'] && ! empty( $field['value']['value'] ) && is_numeric( $field['value']['value'] ) ) {
+											$attachment_url = wp_get_attachment_image_url( (int) $field['value']['value'], 'thumbnail' );
+											$img_url        = $attachment_url ? $attachment_url : '';
+										}
 										?>
 											<img src="<?php echo esc_url( $img_url ); ?>" alt="<?php esc_attr_e( 'The currently selected image preview', 'acf' ); ?>" />
 									</div>