From 64ca8e5ebafb4d9cb8431648b0e6ff056786017f Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 6 Sep 2026 11:58:25 +0000 Subject: [PATCH] =?UTF-8?q?lance-graph-ogar:=20rustfmt=20the=20six=20bridg?= =?UTF-8?q?e=20files=20=E2=80=94=20#1202=20left=20a=20stray=20blank=20line?= =?UTF-8?q?=20in=20each?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit My defect in #1202, and it turned q2's fmt gate red the moment #1202 landed on main. Deleting each `pub const NAMESPACE` block left two consecutive blank lines where the doc-comment had been; `cargo fmt` removes one per file, six lines total, no other change. I verified #1202 with clippy and tests and never ran `cargo fmt` on the crate. Earlier in the same session I checked fmt explicitly for every other crate I touched; here I did not, and the gate I had just spent the day building is what caught it. It also corrects a measurement I published in that PR and in q2's workflow comment: I claimed `cargo fmt --all` does NOT reach `[patch]`-replaced sibling sources, having observed that `lance-graph-contract`'s drift produced no diff. q2's run reports all six of these files by absolute path (`/home/runner/work/q2/q2/lance-graph/crates/lance-graph-ogar/src/bridges/*.rs`), so it plainly does reach this crate. Whatever distinguishes the two cases, the general claim was too strong for the single observation behind it. Verified: rustfmt --check clean on all six, clippy 0 errors, tests 96 passed. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V --- crates/lance-graph-ogar/src/bridges/medcare_bridge.rs | 1 - crates/lance-graph-ogar/src/bridges/odoo_bridge.rs | 1 - crates/lance-graph-ogar/src/bridges/openproject_bridge.rs | 1 - crates/lance-graph-ogar/src/bridges/redmine_bridge.rs | 1 - crates/lance-graph-ogar/src/bridges/smb_bridge.rs | 1 - crates/lance-graph-ogar/src/bridges/woa_bridge.rs | 1 - 6 files changed, 6 deletions(-) diff --git a/crates/lance-graph-ogar/src/bridges/medcare_bridge.rs b/crates/lance-graph-ogar/src/bridges/medcare_bridge.rs index 014aa43c9..f4cc6f245 100644 --- a/crates/lance-graph-ogar/src/bridges/medcare_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/medcare_bridge.rs @@ -44,7 +44,6 @@ pub use ogar_vocab::ports::HealthcarePort; )] pub type MedcareBridge = UnifiedBridge; - #[cfg(test)] #[allow(deprecated)] // exercises the deprecated bridge alias on purpose mod tests { diff --git a/crates/lance-graph-ogar/src/bridges/odoo_bridge.rs b/crates/lance-graph-ogar/src/bridges/odoo_bridge.rs index 7c1e3bd25..5f842d795 100644 --- a/crates/lance-graph-ogar/src/bridges/odoo_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/odoo_bridge.rs @@ -33,7 +33,6 @@ pub use ogar_vocab::ports::OdooPort; )] pub type OdooBridge = UnifiedBridge; - #[cfg(test)] #[allow(deprecated)] // exercises the deprecated bridge alias on purpose mod tests { diff --git a/crates/lance-graph-ogar/src/bridges/openproject_bridge.rs b/crates/lance-graph-ogar/src/bridges/openproject_bridge.rs index 14f9b70e9..e50a6312e 100644 --- a/crates/lance-graph-ogar/src/bridges/openproject_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/openproject_bridge.rs @@ -31,7 +31,6 @@ pub use ogar_vocab::ports::OpenProjectPort; )] pub type OpenProjectBridge = UnifiedBridge; - /// Compatibility shim — re-exports `ogar_vocab::ports::OPENPROJECT_ALIASES` /// under the pre-migration name so consumers that imported the constant /// from this module still build (codex P2 on PR #570). New code should diff --git a/crates/lance-graph-ogar/src/bridges/redmine_bridge.rs b/crates/lance-graph-ogar/src/bridges/redmine_bridge.rs index 71f9a072b..654e150c6 100644 --- a/crates/lance-graph-ogar/src/bridges/redmine_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/redmine_bridge.rs @@ -25,7 +25,6 @@ pub use ogar_vocab::ports::RedminePort; )] pub type RedmineBridge = UnifiedBridge; - /// Compatibility shim — re-exports `ogar_vocab::ports::REDMINE_ALIASES` /// under the pre-migration name (codex P2 on PR #570). New code should /// reach for the OGAR constant directly. diff --git a/crates/lance-graph-ogar/src/bridges/smb_bridge.rs b/crates/lance-graph-ogar/src/bridges/smb_bridge.rs index 673b8be7d..c9cbeab61 100644 --- a/crates/lance-graph-ogar/src/bridges/smb_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/smb_bridge.rs @@ -32,7 +32,6 @@ pub use ogar_vocab::ports::SmbPort; )] pub type SmbBridge = UnifiedBridge; - #[cfg(test)] #[allow(deprecated)] // exercises the deprecated bridge alias on purpose mod tests { diff --git a/crates/lance-graph-ogar/src/bridges/woa_bridge.rs b/crates/lance-graph-ogar/src/bridges/woa_bridge.rs index ecb8c56f4..b6cd8a145 100644 --- a/crates/lance-graph-ogar/src/bridges/woa_bridge.rs +++ b/crates/lance-graph-ogar/src/bridges/woa_bridge.rs @@ -39,7 +39,6 @@ pub use ogar_vocab::ports::WoaPort; )] pub type WoaBridge = UnifiedBridge; - #[cfg(test)] #[allow(deprecated)] // exercises the deprecated bridge alias on purpose mod tests {