Commit 4fc4c39
committed
Point setup-rust-toolchain at the crate, and record the corrections
A review finding on this PR, verified against the action's own
documentation: `defaults.run.working-directory` governs `run:` steps
only. Each `actions-rust-lang/setup-rust-toolchain` step executes from
GITHUB_WORKSPACE, where this repository is a subdirectory and no
toolchain file is visible, so it would silently install `stable`
instead of the pin. `rust-src-dir` is the input that points it at the
crate — the same directory that now holds the single
`rust-toolchain.toml`, beside `.cargo/config.toml`.
The reviewer's suggested value was the repository root, which was
correct against the commit it read. It is the crate directory here,
because the root toolchain file was removed in the previous commit
rather than kept in sync.
The board's PR entry gains an appended correction rather than an edit,
per its own append-only rule, covering the four claims that first entry
got wrong: the repo did have a toolchain pin, the push trigger is
limited to `main`, `--manifest-path` is not equivalent to running in the
crate directory, and `-D warnings` is no longer unmeasured.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V1 parent 1ea5c85 commit 4fc4c39
2 files changed
Lines changed: 47 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
37 | 63 | | |
38 | 64 | | |
39 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
50 | 57 | | |
51 | 58 | | |
52 | 59 | | |
| |||
80 | 87 | | |
81 | 88 | | |
82 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
83 | 97 | | |
84 | 98 | | |
85 | 99 | | |
| |||
114 | 128 | | |
115 | 129 | | |
116 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
117 | 138 | | |
118 | 139 | | |
119 | 140 | | |
| |||
0 commit comments