From a347d10ea0cd86981e38bba9c9cea761f24ea685 Mon Sep 17 00:00:00 2001
From: James Rosewell <james@51degrees.com>
Date: Sat, 14 Nov 2026 15:59:10 +0000
Subject: [PATCH 1/3] Build the package trees with maven-pmd-plugin 3.28.0

PMD 7.7.0, which maven-pmd-plugin 3.26.0 runs, cannot read Java 25
class files, so the package build stops in pipeline.core's
check-resources-closed check on a JDK 25. The nightly's package build
uses the runner's default JDK, which is now 25 on ubuntu-latest.
maven-pmd-plugin 3.28.0 runs PMD 7.17.0, which reads them.
---
 device-detection/pom.xml | 2 +-
 ip-intelligence/pom.xml  | 2 +-
 location/pom.xml         | 2 +-
 pipeline/pom.xml         | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/device-detection/pom.xml b/device-detection/pom.xml
index a8dc451ad..c4956c462 100644
--- a/device-detection/pom.xml
+++ b/device-detection/pom.xml
@@ -56,7 +56,7 @@
         <maven-site-plugin.version>3.7.1</maven-site-plugin.version>
         <dependency-check-maven.version>6.5.3</dependency-check-maven.version>
         <central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
-        <maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
+        <maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>
 
         <skippackagesign>true</skippackagesign>
         <skipPublishing>false</skipPublishing>
diff --git a/ip-intelligence/pom.xml b/ip-intelligence/pom.xml
index 4650e53be..2274db329 100644
--- a/ip-intelligence/pom.xml
+++ b/ip-intelligence/pom.xml
@@ -45,7 +45,7 @@
         <org.json.version>20211205</org.json.version>
 
         <maven-compiler-plugin.version>3.9.0</maven-compiler-plugin.version>
-        <maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
+        <maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>
         <exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
         <maven-install-plugin.version>2.5.2</maven-install-plugin.version>
         <maven-jar-plugin.version>3.2.2</maven-jar-plugin.version>
diff --git a/location/pom.xml b/location/pom.xml
index 05c2eb72b..53250490b 100644
--- a/location/pom.xml
+++ b/location/pom.xml
@@ -78,7 +78,7 @@
         <maven-jarsigner-plugin.version>3.0.0</maven-jarsigner-plugin.version>
         <maven-gpg-plugin.version>3.0.1</maven-gpg-plugin.version>
         <central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
-        <maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
+        <maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>
 
         <skippackagesign>true</skippackagesign>
         <skipPublishing>false</skipPublishing>
diff --git a/pipeline/pom.xml b/pipeline/pom.xml
index 533f13e51..99c41161a 100644
--- a/pipeline/pom.xml
+++ b/pipeline/pom.xml
@@ -95,7 +95,7 @@
         <maven-project-info-reports-plugin.version>2.6</maven-project-info-reports-plugin.version>
         <maven-site-plugin.version>3.7</maven-site-plugin.version>
         <central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
-        <maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
+        <maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>
 
         <skippackagesign>true</skippackagesign>
         <skipPublishing>false</skipPublishing>

From 866d517b05dde4fdb2a2dd8c12f28741f392641a Mon Sep 17 00:00:00 2001
From: James Rosewell <james@51degrees.com>
Date: Sat, 14 Nov 2026 16:07:45 +0000
Subject: [PATCH 2/3] Leave the dangling doc comment check out of pipeline.did
 on JDK 23 and later

javac 23 added a lint check for a documentation comment attached to no
declaration. The OWID source that pipeline.did compiles in has one
(PublicKeySchedule.java line 136 at owid-java 23d8da13), and the
module compiles with -Xlint:all and -Werror, so the build stops there on
JDK 25. A profile active only on JDK 23 and later adds
-Xlint:-dangling-doc-comments, as earlier javac does not know the name.
---
 pipeline/pipeline.did/pom.xml | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/pipeline/pipeline.did/pom.xml b/pipeline/pipeline.did/pom.xml
index c5ba43ddc..a925f2780 100644
--- a/pipeline/pipeline.did/pom.xml
+++ b/pipeline/pipeline.did/pom.xml
@@ -153,4 +153,30 @@
         </plugins>
     </build>
 
+    <profiles>
+        <!-- javac 23 and later warn about a documentation comment that is
+             attached to nothing, and the OWID source compiled in has one, so
+             -Werror would fail the build. Those JDKs leave that one check out
+             here. Earlier JDKs do not know the check's name. -->
+        <profile>
+            <id>owid-dangling-doc-comments</id>
+            <activation>
+                <jdk>[23,)</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <configuration>
+                            <compilerArgs combine.children="append">
+                                <arg>-Xlint:-dangling-doc-comments</arg>
+                            </compilerArgs>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>

From 50331fbffa595aa87a4ace94cf9888603a40ac38 Mon Sep 17 00:00:00 2001
From: James Rosewell <james@51degrees.com>
Date: Sat, 14 Nov 2026 16:14:12 +0000
Subject: [PATCH 3/3] Remove a doc comment attached to nothing from
 EvidenceKeyFilterShareUsageTests

javac 23 and later warn about it, and -Werror makes the warning stop the
test compile of pipeline.engines.fiftyone on JDK 25. The comment
described defaults no test below it covers.
---
 .../fiftyone/data/EvidenceKeyFilterShareUsageTests.java      | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/pipeline/pipeline.engines.fiftyone/src/test/java/fiftyone/pipeline/engines/fiftyone/data/EvidenceKeyFilterShareUsageTests.java b/pipeline/pipeline.engines.fiftyone/src/test/java/fiftyone/pipeline/engines/fiftyone/data/EvidenceKeyFilterShareUsageTests.java
index 33eacefc6..1d32b342b 100644
--- a/pipeline/pipeline.engines.fiftyone/src/test/java/fiftyone/pipeline/engines/fiftyone/data/EvidenceKeyFilterShareUsageTests.java
+++ b/pipeline/pipeline.engines.fiftyone/src/test/java/fiftyone/pipeline/engines/fiftyone/data/EvidenceKeyFilterShareUsageTests.java
@@ -56,11 +56,6 @@ private static EvidenceKeyFilterShareUsage defaults() {
             false);
     }
 
-    /**
-     * By default headers other than Cookie are shared, cookies, session
-     * values and query string parameters only when their names start with
-     * 51D_, and any other evidence.
-     */
     /**
      * The whole web request is read by the Usage Sharing Element and never
      * shared as a value, so the filter does not include it.